Skip to content
Permalink
Browse files

Fix image format detection for upper case extensions, e.g. JPG

This regression was introduced in 0.56.0.

Fixes #6137
  • Loading branch information...
bep committed Jul 30, 2019
1 parent 00a238e commit c62bbf7b11d68d52ef11a4c6c70660914c473d08
Showing with 11 additions and 1 deletion.
  1. +10 −0 resources/image_test.go
  2. +1 −1 resources/resource.go
  3. BIN resources/testdata/sunrise.JPG
@@ -152,6 +152,16 @@ func TestImageTransformLongFilename(t *testing.T) {
assert.Equal("/a/_hu59e56ffff1bc1d8d122b1403d34e039f_90587_c876768085288f41211f768147ba2647.jpg", resized.RelPermalink())
}

// Issue 6137
func TestImageTransformUppercaseExt(t *testing.T) {
assert := require.New(t)
image := fetchImage(assert, "sunrise.JPG")
resized, err := image.Resize("200x")
assert.NoError(err)
assert.NotNil(resized)
assert.Equal(200, resized.Width())
}

// https://github.com/gohugoio/hugo/issues/5730
func TestImagePermalinkPublishOrder(t *testing.T) {
for _, checkOriginalFirst := range []bool{true, false} {
@@ -209,7 +209,7 @@ func (r *Spec) newResource(sourceFs afero.Fs, fd ResourceSourceDescriptor) (reso
fd.RelTargetFilename = sourceFilename
}

ext := filepath.Ext(fd.RelTargetFilename)
ext := strings.ToLower(filepath.Ext(fd.RelTargetFilename))
mimeType, found := r.MediaTypes.GetFirstBySuffix(strings.TrimPrefix(ext, "."))
// TODO(bep) we need to handle these ambigous types better, but in this context
// we most likely want the application/xml type.
Binary file not shown.

0 comments on commit c62bbf7

Please sign in to comment.
You can’t perform that action at this time.