Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset hugo_0.102.0_Linux-64bit.deb has files in wrong location #10220

Closed
zaitseff opened this issue Aug 28, 2022 · 7 comments
Closed

Asset hugo_0.102.0_Linux-64bit.deb has files in wrong location #10220

zaitseff opened this issue Aug 28, 2022 · 7 comments
Assignees
Milestone

Comments

@zaitseff
Copy link
Contributor

zaitseff commented Aug 28, 2022

Thanks for creating and releasing Hugo!

The latest release asset for Debian, hugo_0.102.0_Linux-64bit.deb, has its built files in the wrong location:

$ dpkg-deb -c hugo_0.102.0_Linux-64bit.deb
-rwxr-xr-x root/root     11347 2022-08-29 02:28 ./LICENSE
-rwxr-xr-x root/root     10927 2022-08-29 02:28 ./README.md
-rwxr-xr-x root/root  55280808 2022-08-29 02:35 ./hugo

If one were to install this DEB file, it would place the hugo binary in the root directory. It should be something like /usr/local/bin/hugo instead. Similarly, LICENSE and README.md should be non-executable and placed in something like /usr/local/share/doc/hugo.

Previous releases using the old build process did exactly that.

@zaitseff
Copy link
Contributor Author

I haven't investigated any other build assets: similar issues may exist with the new build setup.

@bep bep removed the NeedsTriage label Aug 28, 2022
@bep
Copy link
Member

bep commented Aug 28, 2022

I'm pretty sure this is a "Deb thing" only, thanks for the report, I will fix this tomorrow.

@bep bep self-assigned this Aug 28, 2022
@zaitseff
Copy link
Contributor Author

Thanks for the quick response! Yes, it seems that all DEB versions (64bit, ARM64, _extended 64bit, ARM64) have this particular issue.

@brycewray
Copy link

brycewray commented Aug 28, 2022

Ah. Am assuming this is why my usual GitHub Action for building the site (with Embedded Dart Sass) failed, with a hugo: command not found error, after it installed hugo_extended_0.102.0_Linux-64bit.deb:

check_suite_focus=true#step:8:8).sh: line 1: hugo: command not found
Error: Process completed with exit code [12](https://github.com/brycewray/hugo_site/runs/8060357563?

But, as Scarlett O’Hara would remind us, “Tomorrow is another day.” 😄

Note: Locally, the new universal “fat” binary for macOS works just fine. 👍

@bep
Copy link
Member

bep commented Aug 29, 2022

@brycewray yea, thinking about it I should have deleted those Debs when this issue was raised, that would have produced less noise ...

@bep
Copy link
Member

bep commented Aug 29, 2022

Just a note, I checked one of the deb archives in v0.101.0;

root@ubuntu:~/hugo/debtest# dpkg -c hugo_0.101.0_Linux-ARM.deb
drwxr-xr-x 0/0               0 2022-06-16 07:51 ./usr/
drwxr-xr-x 0/0               0 2022-06-16 07:51 ./usr/local/
drwxr-xr-x 0/0               0 2022-06-16 07:51 ./usr/local/bin/
-rwxr-xr-x 0/0        47710208 2022-06-16 07:26 ./usr/local/bin/hugo

Just the binary, no "extra files", which is what I'm going to do here.

bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
@bep bep added this to the v0.102.1 milestone Aug 29, 2022
bep added a commit to gohugoio/hugoreleaser that referenced this issue Aug 29, 2022
And use that in the built-in archives if set.

Also

* Pass the binary file's mode to the archive plugin(s), ref gohugoio/hugo#10220
* Clean up some leftovers from the old plugin package structure.
bep added a commit that referenced this issue Aug 29, 2022
bep added a commit that referenced this issue Aug 29, 2022
bep added a commit that referenced this issue Aug 29, 2022
@bep bep closed this as completed in 79932e7 Aug 29, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants