Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error calling partial: context canceled #10789

Closed
bep opened this issue Mar 4, 2023 · 2 comments · Fixed by #10790
Closed

Error calling partial: context canceled #10789

bep opened this issue Mar 4, 2023 · 2 comments · Fixed by #10790
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.111.2

Comments

@bep
Copy link
Member

bep commented Mar 4, 2023

No description provided.

@bep bep added the Bug label Mar 4, 2023
@bep bep added this to the v0.111.2 milestone Mar 4, 2023
@bep bep self-assigned this Mar 4, 2023
@bep
Copy link
Member Author

bep commented Mar 4, 2023 •
edited
Loading

OK, I see what's happening here:

https://github.com/onweru/compose/blob/master/layouts/partials/functions/getScript.html

  • The above returns a lazily evaluated resource
  • Which means that the partial timeout context is cancelled before the template in execute template gets cancelled.
  • And in this case, the ExecuteAsTemplate also includes a partial ... and boom.

I'll try to create a test for this, but the fix would be to make sure that the execution of ExecuteAsTemplate don't use an old (cancelled context).

@bep bep mentioned this issue Mar 4, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Mar 4, 2023
@bep
Fix "context canceled" with partial
e18c0e0 
Make sure the context used for partial timeouts isn't created based on the incoming
context, as we have cases where this can cancel the context prematurely.

Fixes gohugoio#10789
bep added a commit to bep/hugo that referenced this issue Mar 4, 2023
@bep
Fix "context canceled" with partial
63a6e40 
Make sure the context used for timeouts isn't created based on the incoming
context, as we have cases where this can cancel the context prematurely.

Fixes gohugoio#10789
@bep bep closed this as completed in #10790 Mar 4, 2023
bep added a commit that referenced this issue Mar 4, 2023
@bep
Fix "context canceled" with partial
3bbeb56 
Make sure the context used for timeouts isn't created based on the incoming
context, as we have cases where this can cancel the context prematurely.

Fixes #10789
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.111.2
Development

Successfully merging a pull request may close this issue.

Fix "context canceled" with partial bep/hugo
1 participant
@bep