Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbolic links for root static, content etc. not functioning #2265

Closed
robstarbuck opened this issue Jul 8, 2016 · 1 comment
Closed

Symbolic links for root static, content etc. not functioning #2265

robstarbuck opened this issue Jul 8, 2016 · 1 comment
Assignees
@bep
Labels
Bug Outdated

Comments

@robstarbuck
Copy link
Contributor

This commit suggests that the content folder can be symlinked.

I have tried this with

  1. content as the target with files at the root of the source
  2. content as the target with files insides posts of the source
  3. posts as the target inside a directory called content

I haven't had any luck with any. More details here and here.

Thanks kindly.
@bep bep added the Bug label Jul 9, 2016
@bep bep changed the title Symbolic links for content not functioning Symbolic links for root static, content etc. not functioning Jul 10, 2016
@bep bep mentioned this issue Jul 10, 2016
Closed
bep added a commit to bep/hugo that referenced this issue Sep 8, 2016
@bep
Handle symlink change event
2f4979c 
Hugo 0.16 announced support for symbolic links for the root folders, /content, /static etc., but this got broken pretty fast.

The main problem this commit tries to solve is the matching of file change events to "what changed".

An example:

ContentDir: /mysites/site/content where /mysites/site/content is a symlink to /mycontent

/mycontent:

/mypost1.md
/post/mypost2.md

* A change to mypost1.md (on OS X) will trigger a file change event with name "/mycontent/mypost1.md"
* A change to mypost2.md gives event with name "/mysites/site/content/mypost2.md"

The first change will not trigger a correct update of Hugo before this commit. This commit fixes this by doing a two-step check:

1. Check if "/mysites/site/content/mypost2.md" is within /mysites/site/content
2. Check if  "/mysites/site/content/mypost2.md" is within the real path that /mysites/site/content points to

Fixes gohugoio#2265
@bep bep closed this as completed in 364e69a Sep 11, 2016
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@bep @tychoish
Handle symlink change event
2f2c41d 
Hugo 0.16 announced support for symbolic links for the root folders, /content, /static etc., but this got broken pretty fast.

The main problem this commit tries to solve is the matching of file change events to "what changed".

An example:

ContentDir: /mysites/site/content where /mysites/site/content is a symlink to /mycontent

/mycontent:

/mypost1.md
/post/mypost2.md

* A change to mypost1.md (on OS X) will trigger a file change event with name "/mycontent/mypost1.md"
* A change to mypost2.md gives event with name "/mysites/site/content/mypost2.md"

The first change will not trigger a correct update of Hugo before this commit. This commit fixes this by doing a two-step check:

1. Check if "/mysites/site/content/mypost2.md" is within /mysites/site/content
2. Check if  "/mysites/site/content/mypost2.md" is within the real path that /mysites/site/content points to

Fixes gohugoio#2265
Closes gohugoio#2273
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle symlink change event bep/hugo
2 participants
@bep @robstarbuck