Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema.org: Only show post's own keywords #2635

Closed
brunoamaral opened this issue Oct 25, 2016 · 4 comments
Closed

schema.org: Only show post's own keywords #2635

brunoamaral opened this issue Oct 25, 2016 · 4 comments

Comments

@brunoamaral
Copy link
Contributor

At the moment, the _internal/shchema.html template outputs the full list of tags as part of the <meta itemprop="keywords">.

<!-- Output all taxonomies as schema.org keywords -->
<meta itemprop="keywords" content="{{ range $plural, $terms := .Site.Taxonomies }}
{{ range $term, $val := $terms }}{{ printf "%s," $term }}{{ end }}{{ end }}" />
{{ end }}

My suggestion is to make this conditional so that it's more relevant to search engines.

I'm usure this code would work, but the logic should be close to this:

{{if .IsPage}}{{ range $index, $tag := .Params.tags }} {{ $tag }},{{ end }}
{{ else }}
    {{ range $plural, $terms := .Site.Taxonomies }}
    {{ range $term, $val := $terms }}{{ printf "%s," $term }}{{ end }}
{{ end }}">
@bep bep changed the title Only show post's own keywords schema.org: Only show post's own keywords Oct 25, 2016
brunoamaral added a commit to brunoamaral/hugo that referenced this issue Oct 29, 2016
@bep
Copy link
Member

bep commented Feb 28, 2017

This issue has been automatically marked as stale because it has not been commented on for at least four months.

The resources of the Hugo team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

@bep bep added the Stale label Feb 28, 2017
@bep
Copy link
Member

bep commented Mar 1, 2017

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.

If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

@juh2
Copy link

juh2 commented Apr 11, 2017

I think it is simply wrong to spam the itemprop metadata field with all keywords ever used on a site. That makes the field unusable. So yes, please improve this.

@bep bep closed this as completed in da72805 Jun 28, 2017
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants