Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pagination of multilingual pages is slightly broken #2972
If I add a paginator on a section page which is translated to several languages, two problems appear:
I think 2 may be a consequence of 1. It looks like 1 is going to be annoying to fix, since pagination happens very late in the rendering process. I guess a good way to fix it would be to make pagination pages into proper pages, etc, etc.
Please don't use "broken" unless you have a well defined "correct solution".
There may be work to be done with pagination vs multilingual (had to stop somewhere), but I'm not sure this is one of them.
I see 3 alternatives:
2 would very rarely be correct (as it would need 1:1 translation for all languages, with equal sorting, taxonomy definition etc.), and it isn't cost effective to try to implement some logic around it.
So then it is 1 or 3?
added a commit
Jan 22, 2017
referenced this issue
Jan 22, 2017
I was thinking of 2 above, but as you point out this can't be a general solution because of missing translated pages. In that case, I agree that current behavior is ok.
In a blog-like site, one may want to fall back to a different language instead of skipping a missing translated page. In such mode, then 2 would make sense.
The second problem I reported is fixed by #2976.