Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the twitter card template #3711

Closed
bep opened this issue Jul 17, 2017 · 3 comments
Closed

Improve the twitter card template #3711

bep opened this issue Jul 17, 2017 · 3 comments
Labels
Enhancement Outdated
Milestone
v0.26

Comments

@bep
Copy link
Member

bep commented Jul 17, 2017 •
edited
Loading

It should check

  • Param "image", Param "images"

Also it seems to only include on IsPage.
bep added a commit to gohugoio/gohugoioTheme that referenced this issue Jul 17, 2017
@bep
Add custom Twitter card
cacf0d4 
See gohugoio/hugo#3711
@bep bep added this to the v0.26 milestone Jul 17, 2017
@bep bep closed this as completed in 00b590d Jul 17, 2017
@budparr
Copy link

budparr commented Jul 17, 2017

I think all the internal social templates should do that (i.e. check for "image" as a string).

@bep
Copy link
Member Author

bep commented Jul 17, 2017

Maybe, but that is not what this issue ended up being. I got a little bit lazy.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.26
Development

No branches or pull requests
2 participants
@budparr @bep