New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the twitter card template #3711

Closed
bep opened this Issue Jul 17, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@bep
Member

bep commented Jul 17, 2017

It should check

  • Param "image", Param "images"

Also it seems to only include on IsPage.

@bep bep added the Enhancement label Jul 17, 2017

bep added a commit to gohugoio/gohugoioTheme that referenced this issue Jul 17, 2017

@bep bep added this to the v0.26 milestone Jul 17, 2017

@bep bep closed this in 00b590d Jul 17, 2017

@budparr

This comment has been minimized.

Show comment
Hide comment
@budparr

budparr Jul 17, 2017

I think all the internal social templates should do that (i.e. check for "image" as a string).

budparr commented Jul 17, 2017

I think all the internal social templates should do that (i.e. check for "image" as a string).

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jul 17, 2017

Member

Maybe, but that is not what this issue ended up being. I got a little bit lazy.

Member

bep commented Jul 17, 2017

Maybe, but that is not what this issue ended up being. I got a little bit lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment