New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build site(s) when template parsing fails #5290

Closed
bep opened this Issue Oct 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@bep
Member

bep commented Oct 6, 2018

This came up while working with #5284 -- the intention was maybe OK (you may at least get partial result), but it make debugging much harder than it could be with all the similar log statements:

ERROR 2018/10/06 14:14:38 Failed to add  "partials/logo.html": template: partials/logo.html:4: unexpected "}" in operand
ERROR 2018/10/06 14:14:38 Error while rendering "home" in "": template: _default/baseof.html:4:3: executing "main" at <partial "logo" .>: error calling partial: template: "partials/logo.html" is an incomplete or empty template
ERROR 2018/10/06 14:14:38 Error while rendering "home" in "": template: _default/baseof.html:4:3: executing "main" at <partial "logo" .>: error calling partial: Partial "logo" not found
ERROR 2018/10/06 14:14:38 Failed to rebuild site: logged 3 error(s)

@bep bep added the Enhancement label Oct 6, 2018

@bep bep added this to the v0.50 milestone Oct 6, 2018

@bep bep self-assigned this Oct 6, 2018

bep added a commit to bep/hugo that referenced this issue Oct 7, 2018

bep added a commit to bep/hugo that referenced this issue Oct 7, 2018

bep added a commit to bep/hugo that referenced this issue Oct 7, 2018

bep added a commit to bep/hugo that referenced this issue Oct 8, 2018

bep added a commit to bep/hugo that referenced this issue Oct 9, 2018

bep added a commit to bep/hugo that referenced this issue Oct 11, 2018

bep added a commit to bep/hugo that referenced this issue Oct 15, 2018

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

commands: Show server error info in browser
The main item in this commit is showing of errors with a file context when running `hugo server`.

This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`).

But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files.

Fixes gohugoio#5284
Fixes gohugoio#5290
See gohugoio#5325
See gohugoio#5324

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

commands: Show server error info in browser
The main item in this commit is showing of errors with a file context when running `hugo server`.

This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`).

But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files.

Fixes gohugoio#5284
Fixes gohugoio#5290
See gohugoio#5325
See gohugoio#5324

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

commands: Show server error info in browser
The main item in this commit is showing of errors with a file context when running `hugo server`.

This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`).

But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files.

Fixes gohugoio#5284
Fixes gohugoio#5290
See gohugoio#5325
See gohugoio#5324

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

commands: Show server error info in browser
The main item in this commit is showing of errors with a file context when running `hugo server`.

This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`).

But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files.

Fixes gohugoio#5284
Fixes gohugoio#5290
See gohugoio#5325
See gohugoio#5324

bep added a commit to bep/hugo that referenced this issue Oct 16, 2018

commands: Show server error info in browser
The main item in this commit is showing of errors with a file context when running `hugo server`.

This can be turned off: `hugo server --disableBrowserError` (can also be set in `config.toml`).

But to get there, the error handling in Hugo needed a revision. There are some items left TODO for commits soon to follow, most notable errors in content and config files.

Fixes gohugoio#5284
Fixes gohugoio#5290
See gohugoio#5325
See gohugoio#5324

@bep bep closed this in 35fbfb1 Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment