Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the type attribute in the attribute list for an ordered list does not show up in the final markup #8377

Closed
faraixyz opened this issue Mar 30, 2021 · 3 comments · Fixed by #8426
Closed

Setting the type attribute in the attribute list for an ordered list does not show up in the final markup #8377

faraixyz opened this issue Mar 30, 2021 · 3 comments · Fixed by #8426
Labels
Outdated Upstream
Milestone
v0.83

Comments

@faraixyz
Copy link

faraixyz commented Mar 30, 2021 •
edited
Loading

Title, but here's an example along with the code

What version of Hugo are you using (hugo version)?

$ hugo v0.82.0-9D960784+extended windows/amd64 BuildDate=2021-03-21T17:28:04Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Yes
@bep bep added the Upstream label Mar 30, 2021
@bep bep added this to the v0.83 milestone Mar 30, 2021
@bep
Copy link
Member

bep commented Mar 30, 2021

So, the rendering of these lists happens in Goldmark. I assume he has a "attribute filter" of sorts -- and I'll admit that it's the first I heard of using the type attribute for list elements. But could you create an issue at https://github.com/yuin/goldmark/issues and link back to this issue so we could track it?

@faraixyz faraixyz mentioned this issue Mar 30, 2021
Closed
@jmooring
Copy link
Member

Should be resolved with https://github.com/yuin/goldmark/releases/tag/v1.3.4, released today.

@jmooring jmooring mentioned this issue Apr 15, 2021
Merged
@bep bep closed this as completed in #8426 Apr 16, 2021
bep pushed a commit that referenced this issue Apr 16, 2021
@jmooring @bep
build(deps): bump github.com/yuin/goldmark from 1.3.2 to 1.3.5
3ddffd0 
Updated test per <yuin/goldmark#205>.

Fixes #8377
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Outdated Upstream
Projects
None yet
Milestone
v0.83
Development

Successfully merging a pull request may close this issue.

build(deps): bump github.com/yuin/goldmark from 1.3.2 to 1.3.5
3 participants
@jmooring @bep @faraixyz