Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory scanning command - getFileList #1159

Closed
wants to merge 1 commit into from

Conversation

rustyoz
Copy link
Contributor

@rustyoz rustyoz commented May 23, 2015

I have added a command to list files in a directory.
In conjunction with a partial for a gallery plugin, this allows me to update a photo gallery by simply adding the file to the directory.

the partial gallery.html
and is included at index.html

Signed-off-by: Russell Oliver roliver8143@gmail.com

Signed-off-by: Russell Oliver <roliver8143@gmail.com>
@bep
Copy link
Member

bep commented May 23, 2015

A couple of comments:

  1. You might as well name it ReadDir / readDir ... as that is what it does.
  2. What are urlparts? Some doc and test cases would be good. I guess this is really a file path. So, maybe better with only one argument and filepath.Join it with the workingDir (some tests for input args that tries to list directories outside of that dir would also be good). Also take into account the Windows users who sends forward slashes.
  3. See README / contribution guide lines for input on how to write a commit message

@rustyoz rustyoz closed this May 23, 2015
@rustyoz rustyoz deleted the getFileList branch May 23, 2015 11:33
bep added a commit that referenced this pull request Jul 7, 2020
cfd74b57d Add a config file update step.
5957d8815 Wrap cache configuration in code-toggle
914405c0e capitalization and indentation fix for taxonomies page (#1159)
223b80f42 Fix page kinds shortcode not rendering on Taxonomies page (#1158)
a9b6fa984 Clarify weight description.
29e121681 Warn about zero weights in front matter.
27ce7ba8c Release 0.73.0
e9596b2ee Merge branch 'temp73'
074a270cd releaser: Add release notes to /docs for release of 0.73.0
4f56a9fc0 width fix of expanding code box in documentation (#1156)
f27254d60 css fix of expanding code box in documentation (#1155)
43b576178 Fix incorrect directory name in quick-start (#1154)
16726eacf Add GroupByLastmod
73c31758e Fix for broken link again (#1151)
d07067295 Fix broken link (#1144)
bc0b484d1 Rename taxonomy kinds from taxonomy to term, taxonomyTerm to taxonomy
674d71842 Fix Typo on Docker section of installation page
b87778165 Merge commit 'efa74c5c6e6ff1daddeb5834ea7c69bed2acf171'
c7cdebed3 tpl/crypto: Add hmac
260130cc0 Allow hook template per section/type
1f70519d8 releaser: Add release notes to /docs for release of 0.72.0
8516d540c Merge commit '9e1dcefc5f559944b70d2fa520f6acd5c56a69f2'
c49195c69 common/maps: Add Scratch.Values
78072df81 Add redirect support to the server
90ca0af6b Fix typo in install instructions

git-subtree-dir: docs
git-subtree-split: cfd74b57d968d98f88d3ddaee651d9cbe79b7ce1
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants