Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(docker): radical reduce the image size #3666

Closed
wants to merge 2 commits into from
Closed

perf(docker): radical reduce the image size #3666

wants to merge 2 commits into from

Conversation

ellerbrock
Copy link
Contributor

Docker Image Size

Hello its me again :)
Its weekend which means time to clean up all the mess i done over the week :)
I radical cleaned up the Docker Image to end up with a smaller image size.

Cheers Maik

woop woop

@bep bep requested a review from anthonyfok July 1, 2017 08:20
apk add --no-cache \
dumb-init \
git && \
go get github.com/gohugoio/hugo && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot just "go get" Hugo due to the vendoring. It will never be correct. So while the Docker file may be smaller, it is now not correct.

@bep
Copy link
Member

bep commented Jul 4, 2017

@ellerbrock thanks for this, but we need to keep the "vendored version" of this Docker file.

@bep bep closed this Jul 4, 2017
@ellerbrock
Copy link
Contributor Author

ellerbrock commented Jul 4, 2017

hi @bep,

first at all thanks for your awesome work on hugo, nice to talk to you as person.
but i guess in this case you are wrong because i build and run this container already in production. you can see and test it here:

Run Example (to get hugo --help):

docker run ellerbrock/alpine-hugo

Or do i miss something?

Cheers Maik

@bep
Copy link
Member

bep commented Jul 4, 2017

Or do i miss something?

Yes. Without vendoring it may work, but you have no idea what library versions Hugo uses, so it may break or do the unexpected at any moment.

@ellerbrock
Copy link
Contributor Author

hi @bep,

i see, yeah thats should not be a problem ...
let me change that and test and then i push a updated version ...

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants