-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(docker): radical reduce the image size #3666
Conversation
sorry had my skeleton comments from my https://github.com/ellerbrock/docker-collection still in it.
apk add --no-cache \ | ||
dumb-init \ | ||
git && \ | ||
go get github.com/gohugoio/hugo && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot just "go get" Hugo due to the vendoring. It will never be correct. So while the Docker file may be smaller, it is now not correct.
@ellerbrock thanks for this, but we need to keep the "vendored version" of this Docker file. |
hi @bep, first at all thanks for your awesome work on hugo, nice to talk to you as person.
Run Example (to get hugo --help):
Or do i miss something? Cheers Maik |
Yes. Without vendoring it may work, but you have no idea what library versions Hugo uses, so it may break or do the unexpected at any moment. |
hi @bep, i see, yeah thats should not be a problem ... |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Docker Image Size
Hello its me again :)
Its weekend which means time to clean up all the mess i done over the week :)
I radical cleaned up the Docker Image to end up with a smaller image size.
Cheers Maik