Increase data directory test coverage #4372
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created these tests as I was trying to solve a number of related issues (see below). A comprehensive fix is not trivial because Hugo uses three different three unmarshalers that behave differently for the same data structures. I will likely revert to fixing the regression first before making another attempt at the big picture. To keep changes incremental and easier to review, I'm pushing these test changes first, and I'm initially basing them on the v0.34 branch to demonstrate that the new tests all pass for that release.
@bep or @moorereason, please review this test code. You can merge it onto v0.34 if you wish, but not onto v0.35, as a couple of the new tests will fail there. Otherwise I'll include this commit along with a fix on a separate PR to master.
In this commit:
Expected results are now all built manually / are more precise.
Tests can run against different versions (no linkage errs)