Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase data directory test coverage #4372

Closed
wants to merge 1 commit into from
Closed

Increase data directory test coverage #4372

wants to merge 1 commit into from

Conversation

vassudanagunta
Copy link
Contributor

@vassudanagunta vassudanagunta commented Feb 2, 2018

Created these tests as I was trying to solve a number of related issues (see below). A comprehensive fix is not trivial because Hugo uses three different three unmarshalers that behave differently for the same data structures. I will likely revert to fixing the regression first before making another attempt at the big picture. To keep changes incremental and easier to review, I'm pushing these test changes first, and I'm initially basing them on the v0.34 branch to demonstrate that the new tests all pass for that release.

@bep or @moorereason, please review this test code. You can merge it onto v0.34 if you wish, but not onto v0.35, as a couple of the new tests will fail there. Otherwise I'll include this commit along with a fix on a separate PR to master.

In this commit:

*  Adds retro-coverage for #4361
*  Verifies open issues #4138, #3890, #4366, 4083
*  Removes test reliance on the very code it is testing (hugo/parser package).
   Expected results are now all built manually / are more precise.
   Tests can run against different versions (no linkage errs)
@vassudanagunta
Copy link
Contributor Author

@bep Since this PR was just to demo the new tests against v0.34, and since #4373 includes these new tests plus a v0.35 fix, you can just close the PR if and when you merge that one.

@moorereason moorereason closed this Feb 2, 2018
@vassudanagunta vassudanagunta deleted the new-data-dir-tests branch February 2, 2018 15:55
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants