Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WeightedPages in union etc. #5853

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Conversation

bep
Copy link
Member

@bep bep commented Apr 13, 2019

We introduced a callback func() to get the owner Page in 0.55.0.

Sadly, func is not a comparable type in Go.

This commit replaces the func with a struct pointer that wraps the Page.

Fixes #5850

We introduced a callback func() to get the owner Page in 0.55.0.

Sadly, funcs is  not comparable type in Go.

This commit replaces the func with a struct pointer that wraps the Page.

Fixes gohugoio#5850
@bep bep requested review from moorereason and removed request for moorereason April 13, 2019 11:00
@bep bep merged commit f2795d4 into gohugoio:master Apr 13, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WeightedPage cannot be used in union etc. anymore
1 participant