Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update github.com/tdewolff/minify/v2 v2.9.22 => v2.9.29 #9382

Merged
merged 1 commit into from
Feb 15, 2022
Merged

deps: Update github.com/tdewolff/minify/v2 v2.9.22 => v2.9.29 #9382

merged 1 commit into from
Feb 15, 2022

Conversation

jmooring
Copy link
Member

@jmooring
Copy link
Member Author

Changes to JS minification are substantial, so this is not without risk. However, the longer we wait...

@bep
Copy link
Member

bep commented Jan 14, 2022

There have been 5-6 patch releases we didn't know about? I need to check up on that dependabot -- it seem to only bother me with updates I don't want/care about.

bep
bep reviewed Jan 14, 2022
View reviewed changes
hugolib/resource_chain_test.go Outdated Show resolved Hide resolved
@jmooring jmooring mentioned this pull request Jan 15, 2022
Closed
@anthonyfok
Copy link
Member

@jmooring I'm sorry for inadvertently causing a merge conflict when I merged #9294 which bumped viper to 1.10.1. I hope I resolved that merge conflict correctly, so this PR may be "squashed and merged" after review.

@anthonyfok
Copy link
Member

There have been 5-6 patch releases we didn't know about? I need to check up on that dependabot -- it seem to only bother me with updates I don't want/care about.

I suspect Dependabot was holding back some PRs as a way to avoid merge conflict. As soon I as merged the bump to viper 1.10.1:

The missing Dependabot "github.com/tdewolff/minify/v2 v2.9.22 => v2.9.28" PR was finally posted:

Not that the new minify depends on a newer version of viper, but probably merely because the two PRs modify adjacent lines in go.mod that Dependabot wanted to enforce the "correct" merge order to avoid nasty merge conflicts?

@jmooring jmooring changed the title deps: Update github.com/tdewolff/minify/v2 v2.9.22 => v2.9.28 deps: Update github.com/tdewolff/minify/v2 v2.9.22 => v2.9.29 Jan 18, 2022
@jmooring jmooring requested a review from bep January 18, 2022 18:28
@jmooring
Copy link
Member Author

Please review.

anthonyfok
anthonyfok approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@anthonyfok anthonyfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not bep, but...) Looks good to me! :-)

@anthonyfok anthonyfok added this to the v0.93.0 milestone Feb 9, 2022
@jmooring
Copy link
Member Author

@bep A gentle nudge...

@bep bep merged commit 923419d into gohugoio:master Feb 15, 2022
@jmooring jmooring deleted the upgrade-tdewolff-minify branch February 15, 2022 18:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anthonyfok anthonyfok anthonyfok approved these changes

@bep bep Awaiting requested review from bep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.93.0
3 participants
@jmooring @bep @anthonyfok