Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Cupper #565

Closed
zwbetz-gh opened this issue Feb 15, 2019 · 4 comments
Closed

Cupper #565

zwbetz-gh opened this issue Feb 15, 2019 · 4 comments

Comments

@zwbetz-gh
Copy link

Theme submission

Link to my theme repository: https://github.com/zwbetz-gh/cupper-hugo-theme

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Feb 15, 2019

Hey Zachary,

thank you for porting another theme to Hugo 👍

The theme looks fine and is ready to be added. However, with #547 custom content in exampleSite will not be used anymore. The content from https://github.com/gohugoio/hugoBasicExample will be used instead. Right now, your theme's demo just has a homepage without content and doesn't showcase custom shortcodes that are shipped with cupper.

As you can read here we're about to update the content in the hugoBasicExample to avoid issues such as those above.

I'll talk @onedrawingperday and we'll let you know what's the best way to proceed.

@zwbetz-gh
Copy link
Author

Hey @digitalcraftsman,

Thank you for the review.

Yeah the new content sourcing policy makes things tricky -- just let me know.

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Feb 16, 2019

Depending on how the revised content from the hugoBasicExample will look like we might be able to use it in the future. For now, I've white-listed your theme because of the issues mentioned above, meaning that the demo's content is provided by you.

Nonetheless, your theme should appear soon on Hugo's theme site. As usual, I'll promote your theme on Hugo's official Twitter account.

@zwbetz-gh
Copy link
Author

I appreciate it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants