Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

[Q] How to migrate theme without the posts for using Hugo Basic Example #556

Closed
serg opened this issue Feb 3, 2019 · 5 comments
Closed

Comments

@serg
Copy link

serg commented Feb 3, 2019

According #547 we move to the new format for adding content examples for themes.
I am maintaining the Yourfolio theme and I don't using the post items for it. Also, the content is neutral as possible.

Could you please advise how to migrate my theme (and themes that has the homepage and no posts) to follow Hugo Basic Example?

Also, the content is force us to use the menu items from Hugo Basic Example project. For example, the creating-a-new-theme.md file contain the definition of the menu.main.parent key for page (tutorials) that didn't exist:

menu:
  main:
    parent: tutorials

Could you please advise how to properly use this? I suppose, the idea is related with the Hugo lookup rules for templates. Is it could be flexible for any type of themes at current moment?

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Feb 3, 2019

Hello @serg

The plan is to expand the Hugo Basic Example for more use cases.

I had a cursory look of your theme’s repo and there shouldn’t be a problem once we push the changes to the Hugo Basic repo along with a few modifications on your part.

However this work will be done in the second half of this month by us, so we will offer guidance once everything is in place.

Also thank you for opening this issue. Hopefully it will be helpful to other theme authors as well.

#547 was somewhat of a breaking change but we really had to do it.

Thank you for your understanding.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Feb 3, 2019

@serg

To get an idea of where we are headed I opened gohugoio/hugoBasicExample#17 which will be part of the upcoming changes in the Hugo Basic Example.

The plan is to make the content of the Hugo Basic Example more modular, so that a theme like yours (that is meant for portfolios) can call specific placeholder content from the repo through the templates under exampleSite/layouts

@serg
Copy link
Author

serg commented Feb 3, 2019

Hello @onedrawingperday,

Thank you for your reply and thank you for sharing the plans about upgrading the Hugo Basic Example!

No worries at all, I think we are totally understand the reason for #547 and could update our themes as well.

We will be waiting for any updates about the improvements for Hugo Basic Example project.

We are appreciate the work for adding the upgrades!

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Feb 23, 2019

@serg I have decided that it would be best to add your theme to the white list, so that your theme's demo is published as it was before.

I am planning to provide a different setup for portfolio themes in the Hugo Basic Example than what you use in this theme.

So once #583 is merged this issue will be closed.

@serg
Copy link
Author

serg commented Feb 24, 2019

@onedrawingperday,
Thank you for doing this! I appreciate this opportunity!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants