Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image load issue when crop only with width #37

Closed
bayuaji opened this issue Oct 1, 2019 · 2 comments
Closed

Image load issue when crop only with width #37

bayuaji opened this issue Oct 1, 2019 · 2 comments
Assignees
@baskarap
Labels
enhancement New feature or request

Comments

@bayuaji
Copy link

bayuaji commented Oct 1, 2019

Steps to reproduce

Open this image and you'll find that image not loaded at all.

.../darkroom/gofresh/v2/images/uploads/1c6561c7-87f8-4fa0-a480-f9386dbbed28_Shuffle-Subscription-In-Final.jpg?w=686&fit=crop&auto=compress

Observed result
Expected result

Old version support this query param

.../uploads/c0c65eee-9c64-49e9-af21-6e2378ec96fa.jpg?w=686&fit=crop&auto=compress

This query param include width, crop and compress and calculate height based on image ratio and width.
@bayuaji bayuaji added the bug Something isn't working label Oct 1, 2019
@baskarap baskarap added enhancement New feature or request and removed bug Something isn't working labels Oct 1, 2019
@baskarap
Copy link
Member

baskarap commented Oct 1, 2019

Thanks for reporting this, we weren't aware of this support before and I will pick this up.

@baskarap baskarap self-assigned this Oct 1, 2019
@baskarap baskarap mentioned this issue Oct 3, 2019
Merged
@baskarap
Copy link
Member

baskarap commented Oct 4, 2019

This is done, so I am closing this issue.

@baskarap baskarap closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baskarap baskarap

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bayuaji @baskarap