Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit breaking at Weaver #21

Open
rShetty opened this issue Feb 18, 2019 · 2 comments
Open

Circuit breaking at Weaver #21

rShetty opened this issue Feb 18, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rShetty
Copy link
Contributor

rShetty commented Feb 18, 2019

  • Introduce and implement circuit breaker pattern for weaver
@rShetty rShetty added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 18, 2019
@gwthm-in gwthm-in self-assigned this Feb 22, 2019
@kartik7153
Copy link
Member

Why do we need a circuit breaker here? It's a proxy right. What fallbacks you will be implementing for this?

@rShetty
Copy link
Contributor Author

rShetty commented Mar 27, 2019

@rShetty This has not been well thought yet, but we would need a way to actively check for failures from downstreams and fallback to a user configured standard fallbacks. Needs analysis, more on how it is done in Envoy here: https://www.envoyproxy.io/learn/circuit-breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rShetty @gwthm-in @kartik7153