Update Dockerfile

Should create the base layer of apk add first so the cache is not invalidated when code changes Should not apk/apt upgrade in docker images (bloats image)
gojp · Jan 2, 2020 · 279a368 · 279a368
1 parent 41818f5
commit 279a368
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,12 +1,13 @@
 FROM golang:1.12.5-alpine
 
+RUN apk add --update --no-cache git make \
+    && go get golang.org/x/tools/go/vcs
+
 COPY . $GOPATH/src/github.com/gojp/goreportcard
 
 WORKDIR $GOPATH/src/github.com/gojp/goreportcard
 
-RUN apk update && apk upgrade && apk add --no-cache git make \
-        && go get golang.org/x/tools/go/vcs \
-        && ./scripts/make-install.sh
+RUN ./scripts/make-install.sh
 
 EXPOSE 8000