Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code refactoring: event dispatcher #57

Closed
cfc4n opened this issue May 6, 2022 · 0 comments · Fixed by #58
Closed

code refactoring: event dispatcher #57

cfc4n opened this issue May 6, 2022 · 0 comments · Fixed by #58
Labels
invalid This doesn't seem right

Comments

@cfc4n
Copy link
Member

cfc4n commented May 6, 2022

ATT

https://github.com/ehids/ecapture/blob/5c9b871e42db6f4f564773b1d778f6e65c1ae271/user/imodule.go#L249-L252

this.Writer() rewrite to Dispatcher() interface for child.

https://github.com/ehids/ecapture/blob/5c9b871e42db6f4f564773b1d778f6e65c1ae271/user/probe_openssl.go#L286-L292
empty value check is ugly.
@cfc4n cfc4n added the invalid This doesn't seem right label May 6, 2022
@cfc4n cfc4n linked a pull request May 9, 2022 that will close this issue
code refactoring: event dispatcher #58
Merged
@cfc4n cfc4n mentioned this issue May 9, 2022
Merged
@cfc4n cfc4n closed this as completed in #58 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

code refactoring: event dispatcher gojue/ecapture
1 participant
@cfc4n