Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please increase versionCode with each release #5

Closed
IzzySoft opened this issue Jun 13, 2022 · 15 comments
Closed

Please increase versionCode with each release #5

IzzySoft opened this issue Jun 13, 2022 · 15 comments
Labels
state: done Completed ✓ type: enhancement New feature or request

Comments

@IzzySoft
Copy link
Contributor

First thanks for your wonderful app! I've just noticed that the second release still shows versionCode:1. like the first one. As Android uses versionCode to tell versions apart, suggesting higher versionCodes as updates, increasing it with each release is essential. So may I kindly suggest doing so?

As your app is built using Flutter, this line needs to be adjusted for that, For the currently latest version it should read

version: 1.1.0+2

(syntax is: version: <versionName>+<versionCode>). If no versionCode is set here, Flutter always defaults to 1.

Thanks in advance!

@gokadzev
Copy link
Owner

@IzzySoft Fixed, Thank you!

@IzzySoft
Copy link
Contributor Author

Thanks – also in the name of the users – already got feedback from delighted new users who found your app via my repo (be welcome to link there from your readme, if you wish even with a badge; updates will be fetched automatically within 24h of your tagging a new release with an APK attached).

@gokadzev
Copy link
Owner

Thanks – also in the name of the users – already got feedback from delighted new users who found your app via my repo (be welcome to link there from your readme, if you wish even with a badge; updates will be fetched automatically within 24h of your tagging a new release with an APK attached).

Done ✅

@IzzySoft
Copy link
Contributor Author

Cool, thanks!

@gokadzev gokadzev added type: enhancement New feature or request state: done Completed ✓ labels Jun 19, 2022
@gokadzev
Copy link
Owner

@IzzySoft ig after major update release there is problem. update isn't detected on izzydroid. can you check it?

@IzzySoft
Copy link
Contributor Author

"These are not the droids you're looking for" 🤖 😄

You've changed the applicationId, so you must look at … that applicationId. The old one is marked for deletion now (due at new year's eve, giving users about half a year to realize: I've included a comment with the old ID to make them aware), the new one was established after my updater informed me about the issue (last night, so changes become visible with the next sync in about 1 hour).

TL;DR: No worries, all is under control 😃 But you might wish to adjust the URL behind the IzzyOnDroid badge in the Readme, replacing the me.musify at the end with the new package name, com.gokadzev.musify.

@IzzySoft
Copy link
Contributor Author

PS: Mind establishing Fastlane structures in your repo, so you can stay in control of description, screenshots etc? If you want to, I can open a PR with what's currently established for your app in my repo.

@gokadzev
Copy link
Owner

PS: Mind establishing Fastlane structures in your repo, so you can stay in control of description, screenshots etc? If you want to, I can open a PR with what's currently established for your app in my repo.

that would be great.

@IzzySoft
Copy link
Contributor Author

There you go 😃

@gokadzev
Copy link
Owner

Thanks

@IzzySoft
Copy link
Contributor Author

Gladly! Thanks for already updating it 😃 I've just set up to pull it along with releases, so your changes should be reflected once the next release got pulled.

@gokadzev
Copy link
Owner

gokadzev commented Jun 1, 2023

@IzzySoft Hello, sorry for tagging. is it normal that Musify isn't updating in your repository anymore? or is it because it is added on fdroid?

@IzzySoft
Copy link
Contributor Author

IzzySoft commented Jun 1, 2023

What do you mean with not updating? Your latest release is 5.3.0 – the latest version in my repo is… 5.3.0. What am I missing? But as we're here: I take it you want your app to stay in my repo, though it's available at F-Droid.org now?

@gokadzev
Copy link
Owner

gokadzev commented Jun 1, 2023

What do you mean with not updating? Your latest release is 5.3.0 – the latest version in my repo is… 5.3.0. What am I missing?

Strange, it was showing 5.2.0 until this time in your repo.

But as we're here: I take it you want your app to stay in my repo, though it's available at F-Droid.org now?

Why not? I was just curious why it was showing 5.2.0 when there was a newer version available.

@IzzySoft
Copy link
Contributor Author

IzzySoft commented Jun 1, 2023

Strange, it was showing 5.2.0 until this time in your repo.

Maybe cashing issue in your browser? Dunno, I didn't touch anything to make it show up for you 😉 Can't hurt to ask (unless asking for hurt), right. To rule the cache out, you can try in a private window should it happen again. But sure I'll check when asked – could well be my updater failing for some reason not-so-obvious from the outside.

Why not?

No prob, just wanted to make sure. Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: done Completed ✓ type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants