-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the command count to the commands #62
Comments
@lenormf I need to check the code to see if this is possible. Is there a use case for this? |
I've implemented a
But I would like to simply bind a key to the |
@lenormf It never occurred to me that we could implement bookmarks with commands. This could be interesting. In the meantime, I have looked at the code a little bit and there doesn't seem like an easy way to do this so it may take some time. |
@lenormf I have been thinking about bookmarks. If we pass count variable as you suggested then I think we still won't be able to list available bookmarks to the user to choose from, am I right? |
My implementation stores the saved paths in files, so listing all the bookmarks is a easy as walking through all those files and displaying their contents. The idea behind using counts is that I would be able to save/load a bookmark in just two keystrokes, as opposed to issuing the
|
So there are two parts to a bookmark implementation. We need to be able to save the current directory as a bookmark (e.g. I'm asking because I was thinking second part could be implemented as such. Assume bookmarks are saved in a file. When we run Then the first part could also be implemented in a similar fashion. When a user run |
I only need a single command in my implementation, what would be
If you know how/where the bookmarks are stored, you also know which ones have been saved, don't you? Unless you meant there's no logical place where the code to display all the bookmarks would be triggered in an implementation where the ID is hit first? In any case, I thought of using counts first because I thought it would be easy to add them to the shell environment, and they would allow access to bookmarks using max. 2 strokes. That also raises another question, is there any use for counts as a part of the environment? Should another issue dedicated to bookmarks be created, or should this one be renamed? |
I don't mind having a single command or two commands for this purpose as long as it works. I have now opened a new issue (#76) for bookmarks. Bookmarks were the original motivation for this feature. If we can implement bookmarks without this feature maybe we can leave this issue here with a low priority until another possible use case comes up. |
Hi,
It'd be convenient to have the command count passed as an environment variable to the commands, like
${count}
.Example:
Thanks.
The text was updated successfully, but these errors were encountered: