Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds broken on arm7 (32-bit arch) #420

Closed
dhui opened this issue Jul 28, 2020 · 4 comments
Closed

Builds broken on arm7 (32-bit arch) #420

dhui opened this issue Jul 28, 2020 · 4 comments

Comments

@dhui
Copy link
Member

dhui commented Jul 28, 2020

Describe the Bug
Releases do not contain pre-built binaries due to an error:

cd ./cmd/migrate && CGO_ENABLED=0 GOOS=linux GOARCH=arm GOARM=7 go build -a -o ../../cli/build/migrate.linux-armv7 -ldflags='-X main.Version=4.12.0 -extldflags "-static"' -tags 'postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver firebird neo4j file go_bindata github github_ee aws_s3 google_cloud_storage godoc_vfs gitlab' .

# github.com/neo4j/neo4j-go-driver/neo4j/internal/packstream

../../../../../../pkg/mod/github.com/neo4j/neo4j-go-driver@v1.8.0/neo4j/internal/packstream/packer.go:130:10: constant 4294967295 overflows int

../../../../../../pkg/mod/github.com/neo4j/neo4j-go-driver@v1.8.0/neo4j/internal/packstream/packer.go:167:9: constant 4294967296 overflows int

Makefile:11: recipe for target 'build-cli' failed

This appears to be caused by the new neo4j Go driver.

Easiest and quickest way to fix would be to drop support/builds for arm7 or neo4j.

Steps to Reproduce
Run: make build-cli or GOOS=linux GOARCH=arm GOARM=7 go build -tags 'postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver firebird neo4j file go_bindata github github_ee aws_s3 google_cloud_storage godoc_vfs gitlab' .

Expected Behavior
Builds should succeed

Migrate Version
v4.12.0

@dhui
Copy link
Member Author

dhui commented Jul 28, 2020

Opened a PR to fix the upstream neo4j driver

@dhui
Copy link
Member Author

dhui commented Jul 31, 2020

Not sure if more people use arm7 or neo4j e.g. how to minimize impact of a quick fix

@2hdddg
Copy link

2hdddg commented Aug 3, 2020

Pull request for this is now here: neo4j/neo4j-go-driver#129

@dhui
Copy link
Member Author

dhui commented Aug 4, 2020

Fixed in v4.12.2

@dhui dhui closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants