Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

dep init fails if any dependency has an invalid symlink named 'vendor' #1197

Closed
spenczar opened this issue Sep 21, 2017 · 3 comments
Closed

Comments

@spenczar
Copy link
Contributor

What version of dep are you using (dep version)?

v0.3.1-16-g5e004f4

What dep command did you run?

go get github.com/spenczar/demo_dep_issue_1197
cd $GOPATH/src/github.com/spenczar/demo_dep_issue_1197
dep init

See https://github.com/spenczar/demo_dep_issue_1197 for the stdout and stderr text, but the important bit is this:

(1/2) Wrote github.com/Masterminds/vcs@v1.12.0
(2/2) Failed to write github.com/Masterminds/glide@v0.12.3
safe write of manifest and lock: error while writing out vendor tree: failed to write dep tree: failed to strip vendor from github.com/Masterminds/glide: stat /var/folders/07/3tqty4fn0pqdmk8kyscf2g2m0wg_zb/T/dep643738718/vendor/github.com/Masterminds/glide/testdata/path/x/vendor: no such file or directory

What did you expect to see?

Successful vendoring, with all symlinks named vendor that point to real directories removed. Ones that are invalid can be ignored.

What did you see instead?

Dep gives up if it runs into any symlinks named vendor that point to a bogus location - even in a testdata folder.

@ibrasho
Copy link
Collaborator

ibrasho commented Sep 21, 2017

Does #1191 solve this issue?

@spenczar
Copy link
Contributor Author

@ibrasho, no, I don't believe it does. I still see the same error.

@spenczar
Copy link
Contributor Author

@ibrasho I'm sorry, I was mistaken. For the bazillionth time, I ran go install . instead of go install ./cmd/dep. #1191 does fix this, yes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants