Skip to content

Commit

Permalink
[release-branch.go1.3] runtime: fix nacl amd64p32 flakiness
Browse files Browse the repository at this point in the history
««« CL 102710043 / 5640e19d768d
runtime: fix nacl amd64p32 flakiness

newproc takes two extra pointers, not two extra registers.
On amd64p32 (nacl) they are different.

We diagnosed this before the 1.3 cut but the tree was frozen.
I believe this is causing the random problems on the builder.

Fixes #8199.

TBR=r
CC=golang-codereviews
https://golang.org/cl/102710043
»»»

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/124120044
  • Loading branch information
adg committed Aug 11, 2014
1 parent 329d3ce commit 0752bc8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/pkg/runtime/traceback_x86.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip,
// the SP is two words lower than normal.
sparg = frame.sp;
if(wasnewproc)
sparg += 2*sizeof(uintreg);
sparg += 2*sizeof(uintptr);

// Determine frame's 'continuation PC', where it can continue.
// Normally this is the return address on the stack, but if sigpanic
Expand Down

0 comments on commit 0752bc8

Please sign in to comment.