Skip to content

Commit

Permalink
test: remove nacl checking condition
Browse files Browse the repository at this point in the history
go1.14 drop nacl support, as go1.15 was released, go1.13 is not
supported anymore, nacl is absolutely gone.

Change-Id: I05efb46891ec875b08da8f2996751a8e9cb57d0c
Reviewed-on: https://go-review.googlesource.com/c/go/+/249977
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
cuonglm committed Aug 23, 2020
1 parent 8acbe4c commit 0c3bf27
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 10 deletions.
6 changes: 0 additions & 6 deletions test/fixedbugs/issue13268.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,10 @@ import (
"log"
"os"
"os/exec"
"runtime"
"strings"
)

func main() {
// cannot use temp file on nacl via child process
if runtime.GOOS == "nacl" {
return
}

// create source
f, err := ioutil.TempFile("", "issue13268-")
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion test/fixedbugs/issue21317.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
)

func main() {
if runtime.Compiler != "gc" || runtime.GOOS == "nacl" || runtime.GOOS == "js" {
if runtime.Compiler != "gc" || runtime.GOOS == "js" {
return
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixedbugs/issue22660.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

func main() {
if runtime.GOOS == "nacl" || runtime.GOOS == "js" {
if runtime.GOOS == "js" {
return // no file system available on builders
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixedbugs/issue22662b.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var tests = []struct {
}

func main() {
if runtime.GOOS == "nacl" || runtime.GOOS == "js" {
if runtime.GOOS == "js" {
return // can not exec go tool
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixedbugs/issue9355.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
)

func main() {
if runtime.Compiler != "gc" || runtime.GOOS == "nacl" || runtime.GOOS == "js" {
if runtime.Compiler != "gc" || runtime.GOOS == "js" {
return
}

Expand Down

0 comments on commit 0c3bf27

Please sign in to comment.