Skip to content

Commit

Permalink
Revert "cmd/compile: ignore g register in liveness analysis"
Browse files Browse the repository at this point in the history
This reverts commit ea200340702cf3ccfac7c5db1f11bb65c80971c7 now
that CL 114695 fixed the root cause of #25504.

Change-Id: If437fc832983bd8793bde28ce0e2e64436a0596c
Reviewed-on: https://go-review.googlesource.com/114087
Reviewed-by: David Chase <drchase@google.com>
  • Loading branch information
aclements committed May 31, 2018
1 parent bfdf74b commit 33cd4fb
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/cmd/compile/internal/gc/plive.go
Original file line number Diff line number Diff line change
Expand Up @@ -461,17 +461,6 @@ func (lv *Liveness) regEffects(v *ssa.Value) (uevar, kill liveRegMask) {
for _, reg := range regs[:nreg] {
if reg.GCNum() == -1 {
if ptrOnly {
if reg.String() == "g" {
// Issue #25504: Sometimes we
// spill and reload the g
// register, which this sees
// as a pointer load into the
// g register. The g register
// isn't a GP register and
// can't appear in register
// maps. Ignore it.
continue
}
v.Fatalf("pointer in non-pointer register %v", reg)
} else {
continue
Expand Down

0 comments on commit 33cd4fb

Please sign in to comment.