Skip to content

Commit

Permalink
[release-branch.go1.10] misc/cgo/testcshared: use file descriptor 30 …
Browse files Browse the repository at this point in the history
…for TestUnexportedSymbols

Backport of CL 108537 to 1.10 release branch.

We were using file descriptor 100, which requires the Linux kernel to
grow the fdtable size. That step may sometimes require a long time,
causing the test to fail. Switch to file descriptor 30, which should
not require growing the fdtable.

Updates #23784
Fixes #25277

Change-Id: I9d25986f3b59bdeb04aa52407b24aa94712aedff
Reviewed-on: https://go-review.googlesource.com/111995
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
ianlancetaylor committed May 8, 2018
1 parent f858dbd commit 516f5cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion misc/cgo/testcshared/main2.c
Expand Up @@ -9,7 +9,7 @@
#include <time.h>
#include <unistd.h>

#define fd (100)
#define fd (30)

// Tests libgo2.so, which does not export any functions.
// Read a string from the file descriptor and print it.
Expand Down
2 changes: 1 addition & 1 deletion misc/cgo/testcshared/src/libgo2/libgo2.go
Expand Up @@ -21,7 +21,7 @@ import (
// that the C code can also use.

const (
fd = 100
fd = 30
)

func init() {
Expand Down

0 comments on commit 516f5cc

Please sign in to comment.