Skip to content

Commit

Permalink
cmd/go: uses SID of group Guests to test ACL
Browse files Browse the repository at this point in the history
The test TestACL failed when ran on a Windows set
up in another language as the "Guest" account
name is translated. The SID of the group of Guests
always exist and is used instead.

Fixes #26658

Change-Id: Ia885d08a9e50563787e389c2d2dc2547881a2943
Reviewed-on: https://go-review.googlesource.com/126598
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
  • Loading branch information
iwdgo authored and alexbrainman committed Jul 28, 2018
1 parent 0090c13 commit 5ad0a52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cmd/go/go_windows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func TestACL(t *testing.T) {
// will make all files created in TestACL/tmp have different
// security attributes to the files created in TestACL.
runIcacls(t, newtmpdir,
"/grant", "guest:(oi)(ci)f", // add Guest user to have full access
"/grant", "*S-1-5-32-546:(oi)(ci)f", // add Guests group to have full access
)

src := filepath.Join(tmpdir, "main.go")
Expand Down

0 comments on commit 5ad0a52

Please sign in to comment.