Skip to content

Commit

Permalink
Revert "[release-branch.go1.10] cmd/compile/internal/gc: OMUL should …
Browse files Browse the repository at this point in the history
…be evaluated when using soft-float"

This reverts commit d74e69c.

Reason for revert: this fix has been backported to 1.11, and that makes
it ineligible for backport to 1.10, since upgrading to 1.11 is a valid
workaround according to https://github.com/golang/go/wiki/MinorReleases.

Also, this triggers a bug on Wasm that would require a backport of
CL 149965, too.

Updates #28688
Updates #28959

Change-Id: I4e56554ea27b5db83bdb1e9d2103dd24e3da8cfc
Reviewed-on: https://go-review.googlesource.com/c/154297
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
  • Loading branch information
FiloSottile committed Dec 14, 2018
1 parent d74e69c commit a9ccbe0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 32 deletions.
2 changes: 1 addition & 1 deletion src/cmd/compile/internal/gc/subr.go
Expand Up @@ -1168,7 +1168,7 @@ func calcHasCall(n *Node) bool {

// When using soft-float, these ops might be rewritten to function calls
// so we ensure they are evaluated first.
case OADD, OSUB, OMINUS, OMUL:
case OADD, OSUB, OMINUS:
if thearch.SoftFloat && (isFloat[n.Type.Etype] || isComplex[n.Type.Etype]) {
return true
}
Expand Down
31 changes: 0 additions & 31 deletions test/fixedbugs/issue28688.go

This file was deleted.

0 comments on commit a9ccbe0

Please sign in to comment.