Skip to content

Commit

Permalink
[dev.regabi] os: disable TestDirFS until #42637 is fixed
Browse files Browse the repository at this point in the history
This test is causing nearly every trybot run on dev.regabi and
dev.typeparams to fail. It's already a release blocker for Go 1.16, so
the failures on the development branches is entirely noise; and
because it causes the trybots to short-circuit, it risks masking
actual Windows-specific failures.

This CL disables the test until a proper solution is decided upon and
implemented for Go 1.16.

Updates #42637.

Change-Id: Ibc85edaed591f1c125cf0b210867aa89d2b0a4b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/286213
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
  • Loading branch information
mdempsky committed Jan 25, 2021
1 parent 8ee3d39 commit be9612a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/os/os_test.go
Expand Up @@ -2689,6 +2689,9 @@ func TestOpenFileKeepsPermissions(t *testing.T) {
}

func TestDirFS(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("workaround for dev.regabi/dev.typeparams until #42637 is fixed")
}
if err := fstest.TestFS(DirFS("./testdata/dirfs"), "a", "b", "dir/x"); err != nil {
t.Fatal(err)
}
Expand Down

0 comments on commit be9612a

Please sign in to comment.