Skip to content

Commit

Permalink
cmd/go: ignore import of "C" when fetching dependencies
Browse files Browse the repository at this point in the history
The change https://golang.org/cl/12192 changed the get code to use the
list of package imports, not the computed list of dependencies, as the
computed list could be out of date if the package changed when using
go get -u.  Computing the dependency list would skip an import of "C",
but that would still be on the package import list.  This changes the
code to skip "C" when walking the import list.

No test--the best test would be to add an import of "C" to
github.com/rsc/go-get-issue-9224-cmd for TestGoGetUpdate.

Fixes #11738.

Change-Id: Id89ddafeade2391d15688bfd142fafd67844a941
Reviewed-on: https://go-review.googlesource.com/12322
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
  • Loading branch information
ianlancetaylor committed Jul 17, 2015
1 parent 955c0fd commit c4f18d5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/cmd/go/get.go
Expand Up @@ -278,6 +278,9 @@ func download(arg string, parent *Package, stk *importStack, getTestDeps bool) {

// Process dependencies, now that we know what they are.
for _, path := range p.Imports {
if path == "C" {
continue
}
// Don't get test dependencies recursively.
download(path, p, stk, false)
}
Expand Down

0 comments on commit c4f18d5

Please sign in to comment.