Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runtime: decrement netpollWaiters in netpollunblock
We used to decrement it in netpollgoready, but that missed the common case of a descriptor becoming ready due to I/O. All calls to netpollgoready go through netpollunblock, so this shouldn't miss any decrements we missed before. Fixes #60782 Change-Id: Ideefefa1ac96ca38e09fe2dd5d595c5dd7883237 Reviewed-on: https://go-review.googlesource.com/c/go/+/503923 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
- Loading branch information
1 parent
21ff9be
commit eaa8419
Showing
3 changed files
with
80 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
// Copyright 2023 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
import ( | ||
"fmt" | ||
"io" | ||
"log" | ||
"net" | ||
"runtime/internal/atomic" | ||
"sync" | ||
"time" | ||
_ "unsafe" // for go:linkname | ||
) | ||
|
||
// The bug is that netpollWaiters increases monotonically. | ||
// This doesn't cause a problem until it overflows. | ||
// Use linkname to see the value. | ||
//go:linkname netpollWaiters runtime.netpollWaiters | ||
var netpollWaiters atomic.Uint32 | ||
|
||
func init() { | ||
register("NetpollWaiters", NetpollWaiters) | ||
} | ||
|
||
func NetpollWaiters() { | ||
listener, err := net.Listen("tcp", "127.0.0.1:0") | ||
if err != nil { | ||
log.Fatal(err) | ||
} | ||
|
||
var wg sync.WaitGroup | ||
wg.Add(1) | ||
go func() { | ||
defer wg.Done() | ||
conn, err := listener.Accept() | ||
if err != nil { | ||
log.Fatal(err) | ||
} | ||
defer conn.Close() | ||
if _, err := io.Copy(io.Discard, conn); err != nil { | ||
log.Fatal(err) | ||
} | ||
}() | ||
|
||
wg.Add(1) | ||
go func() { | ||
defer wg.Done() | ||
conn, err := net.Dial("tcp", listener.Addr().String()) | ||
if err != nil { | ||
log.Fatal(err) | ||
} | ||
defer conn.Close() | ||
for i := 0; i < 10; i++ { | ||
fmt.Fprintf(conn, "%d\n", i) | ||
time.Sleep(time.Millisecond) | ||
} | ||
}() | ||
|
||
wg.Wait() | ||
if v := netpollWaiters.Load(); v != 0 { | ||
log.Fatalf("current waiters %v", v) | ||
} | ||
|
||
fmt.Println("OK") | ||
} |