Skip to content

Commit

Permalink
spec: match syntax for method expressions with implementations
Browse files Browse the repository at this point in the history
A method expression is of the form T.m where T is a type and m
is a method of that type. The spec restricted T essentially to
a type name. Both cmd/compile and go/types accepted any type
syntactically, and a method expression was really just a form
of a selector expression x.f where x denotes a type.

This CL removes the spec syntax restriction from MethodExpr
to match the actual implementation. It also moves MethodExpr
from Operand to PrimaryExpr, because that's what it is.

It still keeps the separate notion of MethodExpr even though
it looks just like a selector expresion, since a MethodExpr
must start with a type rather than a value, and the spec's
syntax expresses this bit of semantics via distinct productions
(e.g., conversions look like calls but also must start with
a type).

Fixes #9060.

Change-Id: Idd84655b5b4f85d7ee53ebf749f73f0414a05f4a
Reviewed-on: https://go-review.googlesource.com/73233
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
griesemer committed Oct 25, 2017
1 parent 4b1f2bb commit f2d5251
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions doc/go_spec.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!--{
"Title": "The Go Programming Language Specification",
"Subtitle": "Version of October 23, 2017",
"Subtitle": "Version of October 25, 2017",
"Path": "/ref/spec"
}-->

Expand Down Expand Up @@ -2278,7 +2278,6 @@ <h3 id="Operands">Operands</h3>
<a href="#Constant_declarations">constant</a>,
<a href="#Variable_declarations">variable</a>, or
<a href="#Function_declarations">function</a>,
a <a href="#Method_expressions">method expression</a> yielding a function,
or a parenthesized expression.
</p>

Expand All @@ -2288,7 +2287,7 @@ <h3 id="Operands">Operands</h3>
</p>

<pre class="ebnf">
Operand = Literal | OperandName | MethodExpr | "(" Expression ")" .
Operand = Literal | OperandName | "(" Expression ")" .
Literal = BasicLit | CompositeLit | FunctionLit .
BasicLit = int_lit | float_lit | imaginary_lit | rune_lit | string_lit .
OperandName = identifier | QualifiedIdent.
Expand Down Expand Up @@ -2554,6 +2553,7 @@ <h3 id="Primary_expressions">Primary expressions</h3>
PrimaryExpr =
Operand |
Conversion |
MethodExpr |
PrimaryExpr Selector |
PrimaryExpr Index |
PrimaryExpr Slice |
Expand Down Expand Up @@ -2740,7 +2740,7 @@ <h3 id="Method_expressions">Method expressions</h3>

<pre class="ebnf">
MethodExpr = ReceiverType "." MethodName .
ReceiverType = TypeName | "(" "*" TypeName ")" | "(" ReceiverType ")" .
ReceiverType = Type .
</pre>

<p>
Expand Down

0 comments on commit f2d5251

Please sign in to comment.