Skip to content

Commit

Permalink
time: improve comments about valid layouts being invalid Parse values
Browse files Browse the repository at this point in the history
Updates #9346
Updates #22135

Change-Id: I7039c9f7d49600e877e35b7255c341fea35890e2
Reviewed-on: https://go-review.googlesource.com/74890
Reviewed-by: Rob Pike <r@golang.org>
  • Loading branch information
ianlancetaylor committed Nov 1, 2017
1 parent 6eb8076 commit fb1fd6a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/time/example_test.go
Expand Up @@ -317,8 +317,8 @@ func ExampleParse() {
t, _ = time.Parse(shortForm, "2013-Feb-03")
fmt.Println(t)

// Valid layouts may not be a valid time value, due to format specifiers
// like _ for zero padding or Z for zone information.
// Some valid layouts are invalid time values, due to format specifiers
// such as _ for zero padding and Z for zone information.
// For example the RFC3339 layout 2006-01-02T15:04:05Z07:00
// contains both Z and a time zone offset in order to handle both valid options:
// 2006-01-02T15:04:05Z
Expand Down
4 changes: 2 additions & 2 deletions src/time/format.go
Expand Up @@ -18,8 +18,8 @@ import "errors"
// reference time looks like so that the Format and Parse methods can apply
// the same transformation to a general time value.
//
// Valid layouts may not be a valid time value for time.Parse, due to formats
// like _ for zero padding or Z for zone information.
// Some valid layouts are invalid time values for time.Parse, due to formats
// such as _ for zero padding and Z for zone information.
//
// Within the format string, an underscore _ represents a space that may be
// replaced by a digit if the following number (a day) has two digits; for
Expand Down

0 comments on commit fb1fd6a

Please sign in to comment.