-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/mail: ParseAddress/String corrupt address #11292
Comments
Nice catch. I overlooked section 5.3 of RFC 2047 in Since this is a new Go 1.5 method, should I fix it now? cc @bradfitz |
@alexcesaro: Go ahead and prepare a fix. We should fix bugs in new code. |
I think to fix that we should:
The first point concerns the new code while the second point concerns existing code and is not a regression: http://play.golang.org/p/nKIl4bflnE Should I fix point 1 only ? both ? none ? |
I see two ways to fix that issue:
Solution 1 code will feel a bit hacky since WordEncoder underlying type is byte. We will need to add a new const like @bradfitz is solution 2 ok? |
CL https://golang.org/cl/16012 mentions this issue. |
The following program fails the panic:
ParseAddress must handle result of Address.String, or else first ParseAddress must fail.
go version devel +514014c Thu Jun 18 15:54:35 2015 +0200 linux/amd64
The text was updated successfully, but these errors were encountered: