-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/mail: fails to escape address #11294
Comments
Dup of #11292. |
@alexcesaro, any chance you have time to look at this for 1.6 still? It would be nice to not have panics in code parsing random inputs. |
It is Dmitry's snippet above that panics not the net/mail code. Also it is not a regression, that bug was discovered before Go 1.5 and is probably there since the beginning. |
Sorry, I'm always confused by the reports saying "this code panics" when the code is just doing |
Yes sorry I wasn't clear :) |
The fix for #11292 should have fixed this. If not we need to add a
character or two to the base64 trigger the CL added.
Russ
|
I am on my phone but I don't think it is the same bug. #11292 was an encoding issue. Here it is a parsing issue: the code thinks there is an encoded-word but it is not. |
The first parse succeeds. Maybe that's a mistake, yes. But either way the
resulting Addr - which could be created by direct field initialization
instead - should survive the round trip `mail.ParseAddress(addr.String())`.
|
CL https://golang.org/cl/17381 mentions this issue. |
The following program fails with the panic:
That name should have been escaped.
go version devel +514014c Thu Jun 18 15:54:35 2015 +0200 linux/amd64
The text was updated successfully, but these errors were encountered: