Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: fix Windows installer license file #11740

Closed
adg opened this issue Jul 16, 2015 · 2 comments
Closed

x/build/cmd/release: fix Windows installer license file #11740

adg opened this issue Jul 16, 2015 · 2 comments
Milestone

Comments

@adg
Copy link
Contributor

@adg adg commented Jul 16, 2015

For some reason the packaging program "light" (part of Wix) doesn't like the LICENSE.rtf that we have been using all along. (It complains about invalid characters for the given code page.)

I've disabled it for the beta, but we should fix it for the 1.5 release. Without LICENSE.rtf the user won't see the project's license when they open the windows installer.

@adg adg added this to the Go1.5 milestone Jul 16, 2015
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 17, 2015

@adg I tried to debug this. As far as I understand I need to send releaselet.go to a buildlet and try running it. I can run buildlet program:

buildlet.exe -listen=127.0.0.1:5936

How do I run commands against it? Do I use gomote? What the command is?

Alex

@adg
Copy link
Contributor Author

@adg adg commented Jul 17, 2015

@alexbrainman One way is to run a local coordinator and a local buildlet.

Since the system usually uses gce for windows builds, you'll need to configure windows-amd64-gce as a "reverse" buildlet instead. Edit dashboard/builders.go to set the IsReverse field on the windows-amd64-gce builder config to true.

$ coordinator -mode dev
$ buildlet -coordinator localhost:8119 -halt=false -reverse windows-amd64-gce

Then you can run release -coordinator localhost:8119 to use your local coordinator and buildlet for the release build.

Or you could just run releaselet.go from a directory that contains a go directory containing a compiled Go tree. (and stub out the stuff in releaselet.go that tries to do the godoc/tour stuff)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.