Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmd/pprof: Dots and slashes aren't allowed in profile names #13195
The docs for runtime/pprof.NewProfile suggest a particular naming format for custom profiles.
The cmd/pprof tool does not load profiles named with that convention, giving the error "parsing profile: unrecognized profile format".
The full variety of import paths may be too much to support, but at the very least '.' and '/' should be allowed.
In addition to the "goroutine" and "threadcreate" profiles, Go code can generate custom profiles using the runtime/pprof package. The user must name these profiles, and the docs recommend using the convention "import/path" to avoid namespace conflicts. This CL updates the pprof tool to be able to parse legacy profiles whose types contain slashes and other non-space characters. This is the upstream fix for golang/go#13195. This change will need to be mirrored to github.com/golang/go/src/cmd/pprof/internal/profile/legacy_profile.go
OK, then I won't touch cmd/pprof on the Go end; I'll leave that to your rebase. Per your comment on the PR, I'll send a CL to update runtime/pprof on the permitted names.…
On Tue, Feb 7, 2017 at 1:07 PM Raul Silvera ***@***.***> wrote: I've merged the fix into the upstream pprof, and will include it in my upcoming rebase of golang pprof. +1 to generating profiles in profile.proto format, though. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#13195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJSK3TwZcaqpXF-tNP4iiDho2bn1YYzNks5raLLIgaJpZM4Ge5vt> .