cmd/pprof: Dots and slashes aren't allowed in profile names #13195
Labels
Milestone
Comments
|
/cc @matloob |
|
Now that we've got support for generating binary profiles, we should use that for all the profiles we generate. Then the legacy parsing code here won't matter. |
|
Never generating legacy profiles will take a bit more work; see e.g. #18641. |
|
It's fine to generate them when debug=1. That's not the problem here. |
Sajmani
added a commit
to Sajmani/pprof
that referenced
this issue
Feb 7, 2017
In addition to the "goroutine" and "threadcreate" profiles, Go code can generate custom profiles using the runtime/pprof package. The user must name these profiles, and the docs recommend using the convention "import/path" to avoid namespace conflicts. This CL updates the pprof tool to be able to parse legacy profiles whose types contain slashes and other non-space characters. This is the upstream fix for golang/go#13195. This change will need to be mirrored to github.com/golang/go/src/cmd/pprof/internal/profile/legacy_profile.go
|
Upstream PR pending review: google/pprof#81 |
|
I've merged the fix into the upstream pprof, and will include it in my upcoming rebase of golang pprof. +1 to generating profiles in profile.proto format, though. |
|
OK, then I won't touch cmd/pprof on the Go end; I'll leave that to your
rebase.
Per your comment on the PR, I'll send a CL to update runtime/pprof on the
permitted names.
…On Tue, Feb 7, 2017 at 1:07 PM Raul Silvera ***@***.***> wrote:
I've merged the fix into the upstream pprof, and will include it in my
upcoming rebase of golang pprof.
+1 to generating profiles in profile.proto format, though.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#13195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJSK3TwZcaqpXF-tNP4iiDho2bn1YYzNks5raLLIgaJpZM4Ge5vt>
.
|
|
https://go-review.googlesource.com/36533 updates the runtime/pprof docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The docs for runtime/pprof.NewProfile suggest a particular naming format for custom profiles.
The cmd/pprof tool does not load profiles named with that convention, giving the error "parsing profile: unrecognized profile format".
I'd expect
go tool pprofto successfully load profiles made using the runtime/pprof package and its instructions. The regexp that's supposed to match custom profiles,\A(\w+) profile: total \d+\n\z, should match the format described in the runtime/pprof docs.The full variety of import paths may be too much to support, but at the very least '.' and '/' should be allowed.
The text was updated successfully, but these errors were encountered: