Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: typo in documentation #15449

Closed
pierrre opened this issue Apr 26, 2016 · 5 comments
Closed

context: typo in documentation #15449

pierrre opened this issue Apr 26, 2016 · 5 comments

Comments

@pierrre
Copy link

pierrre commented Apr 26, 2016

In the documentation:

    //  func Stream(ctx context.Context, out <-chan Value) error {
    //      for {
    //          v, err := DoSomething(ctx)
    //          if err != nil {
    //              return err
    //          }
    //          select {
    //          case <-ctx.Done():
    //              return ctx.Err()
    //          case out <- v:
    //          }
    //      }
    //  }

out <-chan Value should be replaced by out chan<- Value

There is the same typo in golang.org/x/net/context

@bradfitz bradfitz added this to the Go1.7 milestone Apr 26, 2016
@ianlancetaylor
Copy link
Contributor

CC @Sajmani

@bradfitz bradfitz self-assigned this Apr 26, 2016
@bradfitz
Copy link
Contributor

I can take this. I have other work to do in those files coming up shortly here.

@gopherbot
Copy link

CL https://golang.org/cl/22493 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/22494 mentions this issue.

@pierrre
Copy link
Author

pierrre commented Apr 27, 2016

Thank you 👍

gopherbot pushed a commit to golang/net that referenced this issue Apr 27, 2016
Fixes golang/go#15449

Change-Id: Ib4802dc1d9208abc17ef31212d49f03f4f4ed3d1
Reviewed-on: https://go-review.googlesource.com/22494
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants