Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: line numbers are copied when highlighting text #20077

Closed
kevinburke opened this issue Apr 22, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@kevinburke
Copy link
Contributor

commented Apr 22, 2017

I thought I fixed this in golang/tools@0a14ca4, but copying source code with the latest tip also copies the line numbers, in Chromium on my Mac. Maybe a regression, or maybe a different CSS change caused this to break.

@kevinburke kevinburke self-assigned this Apr 22, 2017

@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2017

@kevinburke

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2017

Github does some hacks with CSS ::before to avoid line number copies, I think I will do the same.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 22, 2017

CL https://golang.org/cl/41418 mentions this issue.

@kevinburke

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2017

@golang golang locked and limited conversation to collaborators Apr 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.