Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/devapp: support R= annotations in commit messages #23656
I see people using R= in commit messages, instead of in comments:
Do we want to support R= in commit messages too?
Easy technical change. But do we care about commit message prettiness? One CL was R=go1.11 and we approved it for Go 1.10. Fortunately @tklauser updated the commit message before submitting, but that won't always be the case if we make our tooling support R=go1.N and promote its use.
For those who are heavy
A similar question exists for
Does gerrit support pre-submit hooks? We could have gerrit rewrite away such lines in the commit message. Then out bot would just need to replicate the commit message annotations in gerrit comments.
Same for me. Also, my idea was to save reviewer's time (even though https://golang.org/cl/91055 was then approved for go1.10) and for myself to keep track of my branches/CLs locally. Also being a
I actually propose we stop using magic comments and start using CL-level tags in Gerrit. Gerrit calls the feature "hashtags", and it's now supported by the PolyGerrit UI. We're using them in Perkeep and they're great. It means we can search on them, too.
On their silly name: https://groups.google.com/forum/#!topic/repo-discuss/jZ0raMyuiG0
Example Gerrit search: https://camlistore-review.googlesource.com/q/is:open+-owner:mathieu+-hashtag:op (we use the "op" tag in Perkeep to mean that it's the CL author's turn to do something).