Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: run tests failed with lots of cases in buildmode=shared #26400
What version of Go are you using (
Certainly something is fairly broken here :( It all seems totally erratic though, quite a few things seem to fail differently under gdb than when run directly. The one test that I tried that segfaulted under gdb was trying to write memory past the end of the heap:
%rdi is only 15 bytes before the end of the heap here. But I also see failures to allocate absurd amounts of memory, strings not comparing equal, it's all a mess. It would probably make sense to bisect to see when things started breaking.
I'm not going to have time to look at this for a week or so at best unfortunately.
The vet action assumes that a.Deps is the compilation action for which vet information should be generated. However, when using -linkshared, the action graph is built with a ModeBuggyInstall action to install the shared library built from the compilation action. Adjust the set up of the vet action accordingly. Also don't clean up the working directory after completing the buggy install. Updates #26400 Change-Id: Ia51f9f6b8cde5614a6f2e41b6207478951547770 Reviewed-on: https://go-review.googlesource.com/124275 Run-TryBot: Ian Lance Taylor <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Bryan C. Mills <email@example.com>