Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: search box default text cut off in desktop Safari #27210

Open
willfaught opened this issue Aug 25, 2018 · 8 comments
Open

website: search box default text cut off in desktop Safari #27210

willfaught opened this issue Aug 25, 2018 · 8 comments

Comments

@willfaught
Copy link
Contributor

@willfaught willfaught commented Aug 25, 2018

Sorry, not sure where to file this. https://github.com/golang/blog doesn't track issues.

screen shot 2018-08-24 at 5 56 31 pm

macOS High Sierra 10.13.6 (17G65)
MacBook Pro (Retina, 15-inch, Mid 2015)
Safari Version 11.1.2 (13605.3.8)

@agnivade agnivade changed the title golang.org: search box default text cut off in desktop Safari website: search box default text cut off in desktop Safari Aug 25, 2018
@agnivade
Copy link
Contributor

@agnivade agnivade commented Aug 25, 2018

Does this happen only in a osx+safari combo ? Or in other OSes also ?

@agnivade agnivade added this to the Unplanned milestone Aug 25, 2018
@willfaught
Copy link
Contributor Author

@willfaught willfaught commented Aug 25, 2018

@andybons
Copy link
Member

@andybons andybons commented Aug 25, 2018

Safari desktop only runs on macOS. Mobile views of the blog/golang.org don't have this problem.

@jimmyfrasche
Copy link
Member

@jimmyfrasche jimmyfrasche commented Aug 25, 2018

Works in linux chrome and firefox, but I get a different computed font-family for the input in each. I'm guessing this is an issue with UA stylesheet not being overridden enough.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 25, 2018

Change https://golang.org/cl/131317 mentions this issue: godoc/static: adjust left and right paddings

@agnivade
Copy link
Contributor

@agnivade agnivade commented Aug 25, 2018

Safari desktop only runs on macOS.

I see that they have stopped supporting it on Windows. Didn't know that.

@namusyaka
Copy link
Contributor

@namusyaka namusyaka commented Aug 25, 2018

I think this issue caused by ::-webkit-search-decoration, my patch gets rid of it by specifing -webkit-appearance.

@agnivade
Copy link
Contributor

@agnivade agnivade commented Jan 15, 2019

This seems to have appeared again (#29742) in Safari Version 12.0 (14606.1.36.1.9). Reopening.

@agnivade agnivade reopened this Jan 15, 2019
Bogdan-D pushed a commit to Bogdan-D/godocx that referenced this issue Nov 13, 2019
The input[type="search"] has a pseudo element,
it's ::-webkit-search-decoration and has an original margin.

To get rid of the margin, this commit specifies -webkit-appearance
property to none.

Fixes golang/go#27210

Change-Id: I09bbae5e0b811a3b3fa3a047b97ea45190e75f46
Reviewed-on: https://go-review.googlesource.com/c/131317
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.