Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: symbolic links not dropped from repo [1.11 backport] #29191

Closed
gopherbot opened this issue Dec 12, 2018 · 2 comments
Closed

cmd/go: symbolic links not dropped from repo [1.11 backport] #29191

gopherbot opened this issue Dec 12, 2018 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 12, 2018

@bcmills requested issue #27093 to be considered for backport to the next 1.11 minor release.

@gopherbot, please backport to Go 1.11: incorrect module contents produce incorrect go.sum entries, and the fix is tiny.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Dec 12, 2018

Change https://golang.org/cl/153822 mentions this issue: cmd/go/internal/modfetch: skip symlinks in (*coderepo).Zip

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Dec 14, 2018

Closed by merging b86522f to release-branch.go1.11.

@gopherbot gopherbot closed this Dec 14, 2018
gopherbot pushed a commit that referenced this issue Dec 14, 2018
…coderepo).Zip

Tested manually.

Before:

	$ go mod init golang.org/issue/scratch
	go: creating new go.mod: module golang.org/issue/scratch
	$ go1.11.2 mod download github.com/rogpeppe/test2@latest
	go: finding github.com/rogpeppe/test2 v0.0.11
	$ find $GOPATH -name goodbye
	/tmp/tmp.Y8a8UzX3zD/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/goodbye
	$ cat $(find $GOPATH -name goodbye)
	hello

After:

	$ go mod init golang.org/issue/scratch
	go: creating new go.mod: module golang.org/issue/scratch
	$ go mod download github.com/rogpeppe/test2@latest
	go: finding github.com/rogpeppe/test2 v0.0.11
	$ find $GOPATH -name goodbye
	$ find $GOPATH -name hello
	/tmp/tmp.Zo0jhfLaRs/_gopath/pkg/mod/github.com/rogpeppe/test2@v0.0.11/tests/hello

A proper regression test would require one of:
• a new entry in the vcs-test server (feasible but tedious, and not easily updated by open-source contributors), or
• a way to set up an HTTPS proxy in a script_test, or
• a way to explicitly populate the module cache from the contents of a local repository (#28835).

Fixes #29191
Updates #28835

Change-Id: I72702a7e791f8815965f0f87c82a30df4d6f0151
Reviewed-on: https://go-review.googlesource.com/c/153819
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 561923f)
Reviewed-on: https://go-review.googlesource.com/c/153822
daviddrysdale added a commit to daviddrysdale/trillian that referenced this issue Feb 12, 2019
The calculation of checksums in go.sum was changed in Go 1.11.4
(golang/go#29191) and so any go.sum
contents created with that or a later version are incompatible.
daviddrysdale added a commit to daviddrysdale/trillian that referenced this issue Feb 12, 2019
Go 1.11 automatically checks the GOFLAGS environment variable, so no
need to manually add it to invocations of the Go tools.

Use 1.11.4 specifically because the calculation of go.sum checksums
changed in that version (golang/go#29191),
so using this version means that the checksums are compatible for
Go >= 1.11.4.
@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.