Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialTimeout fails on windows #3016

Closed
rsc opened this issue Feb 14, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@rsc
Copy link
Contributor

commented Feb 14, 2012

Changing to skip test, but need to fix.
@alexbrainman

This comment has been minimized.

Copy link
Member

commented Feb 14, 2012

Comment 1:

Just want to note that TestDialTimeout was working for me here on both 386 and amd64
before rsc reversed it. I can see it fails on builder. Perhaps, it is network setup
related.
Alex
@rsc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2012

Comment 2:

This issue was closed by revision c804efb.

Status changed to Fixed.

@rsc rsc added fixed labels Mar 7, 2012

@mikioh mikioh changed the title windows: net TestDialTimeout fails net: TestDialTimeout fails on windows Mar 29, 2015

mikioh pushed a commit that referenced this issue Apr 2, 2015

Mikio Hara
net: deflake TestDialTimeout
This change makes TestDialTimeout work on almost all the supported
platforms.

Updates #3016.
Updates #3307.
Updates #3867.
Updates #5380.
Updates #5349.

Change-Id: Iacf0ebea23cdd8f6c0333d70c667a5a5f5eb0ed2
Reviewed-on: https://go-review.googlesource.com/8220
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@rsc rsc added this to the Go1 milestone Apr 10, 2015

@rsc rsc removed priority-go1 labels Apr 10, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.