Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/stringer: TestTags is broken with tip Go #30874

Open
heschi opened this issue Mar 15, 2019 · 4 comments
Open

x/tools/cmd/stringer: TestTags is broken with tip Go #30874

heschi opened this issue Mar 15, 2019 · 4 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@heschi
Copy link
Contributor

heschi commented Mar 15, 2019

From https://golang.org/cl/c/tools/+/167860/2#message-67538dc441493e6d29b62dd5f94db08732c1b248, the test is failing with this error on all platforms with tip Go:

stringer: error: 0 packages found
--- FAIL: TestTags (1.42s)
    endtoend_test.go:85: exit status 1
FAIL
FAIL	golang.org/x/tools/cmd/stringer	18.744s
@gopherbot gopherbot added this to the Unreleased milestone Mar 15, 2019
@bradfitz
Copy link
Contributor

Fallout from removing GO111MODULE=auto from the builder environment.

@bcmills, can you fix?

/cc @dmitshur as FYI.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.13 Mar 15, 2019
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Mar 15, 2019
@bcmills
Copy link
Contributor

bcmills commented Mar 15, 2019

I don't think I'll have time to fix it today and I'm OOO next week. This probably needs an owner on the tools team (CC @ianthehat, @matloob).

It looks like @jba modified this test after module mode was released in Go 1.11. Perhaps he has more context on what might need to be updated.
https://github.com/golang/tools/blob/c74ccfb859c02fdeda7e69caf9e7fdccd9a080fc/cmd/stringer/endtoend_test.go#L78-L82

@bcmills bcmills removed their assignment Mar 15, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/167771 mentions this issue: cmd/string: add temporary(?) fix to get string test working in module mode

@bradfitz bradfitz removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Mar 15, 2019
gopherbot pushed a commit to golang/tools that referenced this issue Mar 15, 2019
@bradfitz
cmd/stringer: add temporary(?) fix to get stringer test working in mo…
658e28e 
…dule mode

Updates golang/go#30874

Change-Id: I170ea99b3f06c8bc4cc624e86b80eeb852ea7115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167771
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz
Copy link
Contributor

Okay, x/tools passes again with my temporary(?) hacky fix. I didn't look into why it was failing. I slapped the environment on and it worked, so somebody who knows this code should understand it more before we close this bug.

@bradfitz bradfitz mentioned this issue Mar 15, 2019
Closed
movie-travel-code pushed a commit to elastic/go-langserver that referenced this issue Mar 19, 2019
@bradfitz
cmd/stringer: add temporary(?) fix to get stringer test working in mo…
a85c267 
…dule mode

Updates golang/go#30874

Change-Id: I170ea99b3f06c8bc4cc624e86b80eeb852ea7115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167771
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
jocgir pushed a commit to jocgir/gotools that referenced this issue Apr 29, 2020
@bradfitz
cmd/stringer: add temporary(?) fix to get stringer test working in mo…
8bf5eaf 
…dule mode

Updates golang/go#30874

Change-Id: I170ea99b3f06c8bc4cc624e86b80eeb852ea7115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167771
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ianthehat ianthehat removed their assignment Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@bradfitz @rsc @andybons @ianthehat @bcmills @gopherbot @heschi