Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/stringer: TestTags is broken with tip Go #30874

Open
heschik opened this issue Mar 15, 2019 · 4 comments

Comments

@heschik
Copy link
Contributor

commented Mar 15, 2019

From https://golang.org/cl/c/tools/+/167860/2#message-67538dc441493e6d29b62dd5f94db08732c1b248, the test is failing with this error on all platforms with tip Go:

stringer: error: 0 packages found
--- FAIL: TestTags (1.42s)
    endtoend_test.go:85: exit status 1
FAIL
FAIL	golang.org/x/tools/cmd/stringer	18.744s

@gopherbot gopherbot added this to the Unreleased milestone Mar 15, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Fallout from removing GO111MODULE=auto from the builder environment.

@bcmills, can you fix?

/cc @dmitshur as FYI.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.13 Mar 15, 2019

@bcmills

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

I don't think I'll have time to fix it today and I'm OOO next week. This probably needs an owner on the tools team (CC @ianthehat, @matloob).

It looks like @jba modified this test after module mode was released in Go 1.11. Perhaps he has more context on what might need to be updated.
https://github.com/golang/tools/blob/c74ccfb859c02fdeda7e69caf9e7fdccd9a080fc/cmd/stringer/endtoend_test.go#L78-L82

@bcmills bcmills removed their assignment Mar 15, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 15, 2019

Change https://golang.org/cl/167771 mentions this issue: cmd/string: add temporary(?) fix to get string test working in module mode

@bradfitz bradfitz removed the Soon label Mar 15, 2019

gopherbot pushed a commit to golang/tools that referenced this issue Mar 15, 2019

cmd/stringer: add temporary(?) fix to get stringer test working in mo…
…dule mode

Updates golang/go#30874

Change-Id: I170ea99b3f06c8bc4cc624e86b80eeb852ea7115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167771
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Okay, x/tools passes again with my temporary(?) hacky fix. I didn't look into why it was failing. I slapped the environment on and it worked, so somebody who knows this code should understand it more before we close this bug.

movie-travel-code added a commit to elastic/go-langserver that referenced this issue Mar 19, 2019

cmd/stringer: add temporary(?) fix to get stringer test working in mo…
…dule mode

Updates golang/go#30874

Change-Id: I170ea99b3f06c8bc4cc624e86b80eeb852ea7115
Reviewed-on: https://go-review.googlesource.com/c/tools/+/167771
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.