Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: clarify error messages, make error messages more visible to the user #31668

Open
ianthehat opened this issue Apr 25, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@ianthehat
Copy link

commented Apr 25, 2019

There are a few ways we have problems working on a file, and we need to report them to the user in a way that lets them understand and fix the problem
Some causes are:

  • The opened folder is not inside a valid workspace (module, GOPATH, other)
  • The file is excluded by build tags
  • The file is in an excluded folder (or other build system specific rules)
  • The file is a pure overlay for a package we do not recognize

Each of these may require a different mechanism for detection, a different heuristic to suggest the root cause or fix, and maybe a different way to report the error.

@odeke-em odeke-em changed the title gopls: it is confusing when a go file is not being handled x/tools/cmd/gopls: it is confusing when a go file is not being handled Apr 25, 2019

@gopherbot gopherbot added this to the Unreleased milestone Apr 25, 2019

@stamblerre stamblerre changed the title x/tools/cmd/gopls: it is confusing when a go file is not being handled x/tools/cmd/gopls: clarify error messages, make error messages more visible to the user Jun 5, 2019

@marco-m

This comment has been minimized.

Copy link

commented Jun 12, 2019

Thanks for this ticket Go team! 🙏

@stamblerre stamblerre changed the title x/tools/cmd/gopls: clarify error messages, make error messages more visible to the user x/tools/gopls: clarify error messages, make error messages more visible to the user Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.