Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

Closed
beenshi opened this issue Jun 22, 2019 · 2 comments
Closed

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

beenshi opened this issue Jun 22, 2019 · 2 comments
Labels
NeedsFix
Milestone
Backlog

Comments

@beenshi
Copy link

@beenshi beenshi commented Jun 22, 2019

As in issue #31827, the callee saved register should be saved/restored in sigtramp.

The callee saved registers are handled in sigtramp of sys_darwin_arm.s, but not in sys_linux _arm.s / sys_openbsd_arm.s / sys_netbsd_arm.s.

Though tsan_test.go passed on arm, there are still potential risks.
@agnivade

This comment has been minimized.

Sign in to view
Copy link
Contributor

@agnivade agnivade commented Jun 23, 2019

@cherrymui @ianlancetaylor
@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Jun 23, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Jun 25, 2019

Change https://golang.org/cl/183777 mentions this issue: runtime: save/restore callee-save registers in arm's sigtramp
@agnivade agnivade mentioned this issue Jul 3, 2019
Closed
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@benshi001 benshi001 modified the milestones: Backlog, Go1.14 Oct 11, 2019
@gopherbot gopherbot closed this in 65a1e24 Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix
Projects
None yet
Milestone
  Backlog
6 participants
@beenshi @agnivade @gopherbot @rsc @ianlancetaylor @benshi001
You can’t perform that action at this time.