Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

Closed
beenshi opened this issue Jun 22, 2019 · 2 comments
Closed

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

beenshi opened this issue Jun 22, 2019 · 2 comments
Labels
Milestone

Comments

@beenshi
Copy link

@beenshi beenshi commented Jun 22, 2019

As in issue #31827, the callee saved register should be saved/restored in sigtramp.

The callee saved registers are handled in sigtramp of sys_darwin_arm.s, but not in sys_linux _arm.s / sys_openbsd_arm.s / sys_netbsd_arm.s.

Though tsan_test.go passed on arm, there are still potential risks.

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Jun 23, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 25, 2019

Change https://golang.org/cl/183777 mentions this issue: runtime: save/restore callee-save registers in arm's sigtramp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.