Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: 'go list -test' prints main package twice [1.13 backport] #34328

Closed
gopherbot opened this issue Sep 16, 2019 · 5 comments

Comments

@gopherbot
Copy link

commented Sep 16, 2019

@jayconrod requested issue #34321 to be considered for backport to the next 1.13 minor release.

@gopherbot Please backport to 1.13.1.

CL 195281 is a cherry-pick of CL 195279, which will introduce this issue. These CLs should be cherry-picked together.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

Change https://golang.org/cl/197064 mentions this issue: [release-branch.go1.13] cmd/go: don't split internal test main packages twice

@gopherbot

This comment has been minimized.

Copy link
Author

commented Sep 25, 2019

Closed by merging 94227d2 to release-branch.go1.13.

@gopherbot gopherbot closed this Sep 25, 2019
gopherbot pushed a commit that referenced this issue Sep 25, 2019
…es twice

Fixes #34328

Change-Id: Ia6253038c525089e20a1da64a2c5c9dcc57edd74
Reviewed-on: https://go-review.googlesource.com/c/go/+/195677
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 4d18a7c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/197064
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

Approved as a companion to #34223, which was a regression.

@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@lanfengye2008

This comment has been minimized.

Copy link

commented Sep 26, 2019

Version 1.13.1 has not been fixed

@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@lanfengye2008, that is intentional — 1.13.1 is a security release, which includes only security fixes. There is a reason I updated this issue's milestone.

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.